From 9fc4939ef96987ca533605fed5f3883885ab7331 Mon Sep 17 00:00:00 2001 From: Jhansi Date: Fri, 17 Jan 2020 15:32:38 -0800 Subject: [PATCH] Fix: Changing the function call to generate random numbers Changing the function call to generate random numbers to a more efficient way. Calling random() on Kotlin.ranges. https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.ranges/random.html#random --- .../main/java/com/example/android/diceroller/MainActivity.kt | 2 +- .../main/java/com/example/android/diceroller/MainActivity.kt | 2 +- .../main/java/com/example/android/diceroller/MainActivity.kt | 2 +- .../main/java/com/example/android/diceroller/MainActivity.kt | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/DiceRoller-challenge/app/src/main/java/com/example/android/diceroller/MainActivity.kt b/DiceRoller-challenge/app/src/main/java/com/example/android/diceroller/MainActivity.kt index 67de181..a61c361 100644 --- a/DiceRoller-challenge/app/src/main/java/com/example/android/diceroller/MainActivity.kt +++ b/DiceRoller-challenge/app/src/main/java/com/example/android/diceroller/MainActivity.kt @@ -47,7 +47,7 @@ class MainActivity : AppCompatActivity() { * Click listener for the Roll button. */ private fun rollDice() { - val randomInt = Random().nextInt(6) + 1 + val randomInt= (1..6).random() val resultText: TextView = findViewById(R.id.result_text) resultText.text = randomInt.toString() diff --git a/DiceRoller/app/src/main/java/com/example/android/diceroller/MainActivity.kt b/DiceRoller/app/src/main/java/com/example/android/diceroller/MainActivity.kt index b4d0882..8d837e5 100644 --- a/DiceRoller/app/src/main/java/com/example/android/diceroller/MainActivity.kt +++ b/DiceRoller/app/src/main/java/com/example/android/diceroller/MainActivity.kt @@ -46,7 +46,7 @@ class MainActivity : AppCompatActivity() { private fun rollDice() { // Toast.makeText(this, "button clicked", // Toast.LENGTH_SHORT).show() - val randomInt = Random().nextInt(6) + 1 + val randomInt = (1..6).random() val resultText: TextView = findViewById(R.id.result_text) resultText.text = randomInt.toString() diff --git a/DiceRollerFinal-challenge/app/src/main/java/com/example/android/diceroller/MainActivity.kt b/DiceRollerFinal-challenge/app/src/main/java/com/example/android/diceroller/MainActivity.kt index fbdc99f..55b1df9 100644 --- a/DiceRollerFinal-challenge/app/src/main/java/com/example/android/diceroller/MainActivity.kt +++ b/DiceRollerFinal-challenge/app/src/main/java/com/example/android/diceroller/MainActivity.kt @@ -55,7 +55,7 @@ class MainActivity : AppCompatActivity() { } private fun getRandomDiceImage() : Int { - val randomInt = Random().nextInt(6) + 1 + val randomInt = (1..6).random() return when (randomInt) { 1 -> R.drawable.dice_1 diff --git a/DiceRollerFinal/app/src/main/java/com/example/android/diceroller/MainActivity.kt b/DiceRollerFinal/app/src/main/java/com/example/android/diceroller/MainActivity.kt index d988976..4ba9b40 100644 --- a/DiceRollerFinal/app/src/main/java/com/example/android/diceroller/MainActivity.kt +++ b/DiceRollerFinal/app/src/main/java/com/example/android/diceroller/MainActivity.kt @@ -50,7 +50,7 @@ class MainActivity : AppCompatActivity() { private fun rollDice() { // Toast.makeText(this, "button clicked", // Toast.LENGTH_SHORT).show() - val randomInt = Random().nextInt(6) + 1 + val randomInt = (1..6).random() val drawableResource = when (randomInt) { 1 -> R.drawable.dice_1